More recvfile optimizations

Stefan (metze) Metzmacher metze at samba.org
Thu Apr 10 16:03:02 MDT 2014


Am 10.04.2014 23:59, schrieb Jeremy Allison:
> On Thu, Apr 10, 2014 at 02:24:42PM -0700, Jeremy Allison wrote:
>> On Thu, Apr 10, 2014 at 11:05:14PM +0200, Stefan (metze) Metzmacher wrote:
>>>
>>> I don't have a fix.
>>>
>>> But we would need such check in is_smb2_recvfile_write(), correct?
>>
>> Well, there are two ways of doing it.
>>
>> First one is to add the :
>>
>> smbd_smb2_request_check_session()
>> smbd_smb2_request_check_tcon()
>>
>> calls into is_smb2_recvfile_write(), which is
>> the same way the SMB1 code does it.
> 
> And here is that patch.
> 
> Compiles but not yet tested....

Thanks, but see the comments in my other mail.

We should use smb1srv_open_lookup(), that's simpler...
We should change smbXsrv_open_local_lookup() to ignore now==0,
then we can just pass 0 there and avoid a possible syscall.

metze


More information about the samba-technical mailing list