[PATCHv2] build: make wafsamba CHECK_SIZEOF cross-compile friendly

Gustavo Zacarias gustavo at zacarias.com.ar
Tue Apr 8 08:03:48 MDT 2014

On 04/06/2014 09:38 PM, Andrew Bartlett wrote:

> On Tue, 2014-04-01 at 16:25 -0300, Gustavo Zacarias wrote:
>> Use the same trick as commit 0d9bb86293c9d39298786df095c73a6251b08b7e
>> We do the same array trick iteratively starting from 1 (byte) by powers
>> of 2 up to 32.
> Can you please confirm that the patches don't break other tests, by
> showing a diff of the sorted config.h before and after?
> In this case, it would appear to break utmp.

There was an indentation bug that made CHECK_SIZEOF do nothing on single
items, fixed in the series i've just sent.

> If you could mail back a fixed and current set of patches for all the outstanding cross-compile issues, I'll look at them again.

Sent with the diff on the cover letter for a samba 4.1.6 source (patches
are from master but work the same without any effort).
There are still other tests that could be improved to get the answers
file smaller. With this patches they're pretty much architecture
agnostic for linux.

More information about the samba-technical mailing list