wafsamba/CHECK_LIB: replace dots in library names
jra at samba.org
Mon Apr 7 14:46:11 MDT 2014
On Mon, Apr 07, 2014 at 12:18:15PM +1200, Andrew Bartlett wrote:
> On Thu, 2014-03-27 at 18:30 +0100, Ralph Böhme wrote:
> > Hi
> > just ran across an issue where in CHECK_LIB a library containing a
> > version number including a dot in the library name resulted in a
> > macro defintion including the dot, eg
> > libtracker-sparql-0.16
> > resulting macro:
> > HAVE_LIBTRACKER_SPARQL_0.16
> > Compiler diagnostic:
> > default/include/config.h:945:33: warning: missing whitespace after
> > the macro name [enabled by default]
> > <http://gcc.gnu.org/onlinedocs/cpp/Tokenization.html#Tokenization>:
> > "An identifier is the same as an identifier in C: any sequence of
> > letters, digits, or underscores, which begins with a letter or
> > underscore."
> > I've crafted a small patch which fixes the issue by substituting the
> > dot with an underscore. Review appreciated!
> This looks reasonable.
> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> What do you think?
LGTM - pushed to autobuild.
More information about the samba-technical