wafsamba/CHECK_LIB: replace dots in library names

Andrew Bartlett abartlet at samba.org
Sun Apr 6 18:18:15 MDT 2014

On Thu, 2014-03-27 at 18:30 +0100, Ralph Böhme wrote:
> Hi
> just ran across an issue where in CHECK_LIB a library containing a
> version number including a dot in the library name resulted in a
> macro defintion including the dot, eg
>   libtracker-sparql-0.16
> resulting macro:
> Compiler diagnostic:
>   default/include/config.h:945:33: warning: missing whitespace after
>   the macro name [enabled by default]
> <http://gcc.gnu.org/onlinedocs/cpp/Tokenization.html#Tokenization>:
>    "An identifier is the same as an identifier in C: any sequence of
>    letters, digits, or underscores, which begins with a letter or
>    underscore."
> I've crafted a small patch which fixes the issue by substituting the
> dot with an underscore. Review appreciated!

This looks reasonable.  

Reviewed-by: Andrew Bartlett <abartlet at samba.org>


What do you think?

Andrew Bartlett
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list