wafsamba/CHECK_LIB: replace dots in library names

Ralph Böhme rb at sernet.de
Fri Apr 4 03:04:19 MDT 2014


Hi

On Thu, Mar 27, 2014 at 06:30:44PM +0100, Ralph Böhme wrote:
> just ran across an issue where in CHECK_LIB a library containing a
> version number including a dot in the library name resulted in a
> macro defintion including the dot, eg
> 
>   libtracker-sparql-0.16
> 
> resulting macro:
> 
>   HAVE_LIBTRACKER_SPARQL_0.16
> 
> Compiler diagnostic:
> 
>   default/include/config.h:945:33: warning: missing whitespace after
>   the macro name [enabled by default]
> 
> <http://gcc.gnu.org/onlinedocs/cpp/Tokenization.html#Tokenization>:
> 
>    "An identifier is the same as an identifier in C: any sequence of
>    letters, digits, or underscores, which begins with a letter or
>    underscore."
> 
> I've crafted a small patch which fixes the issue by substituting the
> dot with an underscore. Review appreciated!

*ping*

Thanks!
-Ralph

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de,mailto:kontakt@sernet.de


More information about the samba-technical mailing list