[PATCH] - NetConnEnum implementation

[Shekhar Amlekar]

Hi Christof,

I've modified patch 0001 per your comment.

Thanks,
shekhar.





From:   Christof Schmitt <cs at samba.org>
To:     Jeremy Allison <jra at samba.org>, 
Cc:     Shekhar Amlekar/India/IBM at IBMIN, samba-technical at lists.samba.org
Date:   04/03/2014 10:16 AM
Subject:        Re: [PATCH] - NetConnEnum implementation



On Wed, Apr 02, 2014 at 02:03:35PM -0700, Jeremy Allison wrote:
> On Wed, Apr 02, 2014 at 02:48:36PM +0530, Shekhar Amlekar wrote:
> > Hi Jeremy,
> > 
> > Attached is the patchset with your comment incorporated. Pls let me 
know if
> > you've further comments.
> 
> Looks good to me !
> 
> Reviewed-by: Jeremy Allison <jra at samba.org>
> 
> Can I get a second Team reviewer ?

In "s3: rpc_server/srvsvc: Added routines to count share connections.",
there is a return 0 missing at the end of this function:

+static int share_conn_fn(struct smbXsrv_tcon_global0 *tcon,
+                                                  void *data)
+{
+                struct share_conn_stat *scs = data;
+
+                if (!process_exists(tcon->server_id)) {
+                                return 0;
+                }
+
+                if (strequal(tcon->share_name, scs->sharename)) {
+                                scs->svrid_arr = talloc_realloc(scs->ctx, 
scs->svrid_arr,
+                struct server_id,
+                scs->count + 1);
+                                if (!scs->svrid_arr) {
+                                                return 0;
+                                }
+
+                                scs->svrid_arr[scs->count] = 
tcon->server_id;
+                                scs->count++;
+                }
+}

Everything else looks good:
Reviewed-by: Christof Schmitt <cs at samba.org>

Christof


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-s3-rpc_server-srvsvc-count-open-files-in-NetConnEnum.patch
Type: application/octet-stream
Size: 2857 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140403/33055325/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-s3-rpc_server-srvsvc-count-share-connections-in-NetC.patch
Type: application/octet-stream
Size: 3082 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140403/33055325/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s3-rpc_server-srvsvc-added-routines-to-compute-opens.patch
Type: application/octet-stream
Size: 2688 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140403/33055325/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s3-rpc_server-srvsvc-Added-routines-to-count-share-c.patch
Type: application/octet-stream
Size: 2842 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140403/33055325/attachment-0003.obj>