[PATCH] - NetConnEnum implementation

[Christof Schmitt]

On Wed, Apr 02, 2014 at 02:03:35PM -0700, Jeremy Allison wrote:
> On Wed, Apr 02, 2014 at 02:48:36PM +0530, Shekhar Amlekar wrote:
> > Hi Jeremy,
> > 
> > Attached is the patchset with your comment incorporated. Pls let me know if
> > you've further comments.
> 
> Looks good to me !
> 
> Reviewed-by: Jeremy Allison <jra at samba.org>
> 
> Can I get a second Team reviewer ?

In "s3: rpc_server/srvsvc: Added routines to count share connections.",
there is a return 0 missing at the end of this function:

+static int share_conn_fn(struct smbXsrv_tcon_global0 *tcon,
+			  void *data)
+{
+	struct share_conn_stat *scs = data;
+
+	if (!process_exists(tcon->server_id)) {
+		return 0;
+	}
+
+	if (strequal(tcon->share_name, scs->sharename)) {
+		scs->svrid_arr = talloc_realloc(scs->ctx, scs->svrid_arr,
+						struct server_id,
+						scs->count + 1);
+		if (!scs->svrid_arr) {
+			return 0;
+		}
+
+		scs->svrid_arr[scs->count] = tcon->server_id;
+		scs->count++;
+	}
+}

Everything else looks good:
Reviewed-by: Christof Schmitt <cs at samba.org>

Christof