samba_backup bug fix, error message enhancements, command line enhancement

Brian Martin samba-ml1 at
Wed Sep 25 18:24:38 MDT 2013

I'm a first-time patch submitter, so please guide me if I haven't 
prepared this properly.

The attached patch updates source4/scripting/bin/backup_samba as follows:
     - Fix retention period bug when deleting old backups ($DAYS variable
       could be set, but was ignored).
     - Allow retention period ("DAYS") to be specified as a command line 
     - Allow individual positional parameters to be left at the default
       by specifying "-".
     - Use IS0 8601 standard dates (yyyy-mm-dd instead of mmddyyyy).
     - Display tar exit codes when reporting errors.
     - Don't send error messages to /dev/null, so we know what failed.
     - Suppress useless tar "socket ignored" message.

Thank you for considering this patch.

                                    -Brian Martin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-samba_backup-days.patch
Type: text/x-patch
Size: 4400 bytes
Desc: not available
URL: <>

More information about the samba-technical mailing list