[PATCH] Re: samba_backup bug fix, error message enhancements, command line enhancement

Andrew Bartlett abartlet at samba.org
Fri Sep 27 14:38:05 MDT 2013

On Wed, 2013-09-25 at 17:24 -0700, Brian Martin wrote:
> I'm a first-time patch submitter, so please guide me if I haven't 
> prepared this properly.
> The attached patch updates source4/scripting/bin/backup_samba as follows:
>      - Fix retention period bug when deleting old backups ($DAYS variable
>        could be set, but was ignored).
>      - Allow retention period ("DAYS") to be specified as a command line 
> parameter.
>      - Allow individual positional parameters to be left at the default
>        by specifying "-".
>      - Use IS0 8601 standard dates (yyyy-mm-dd instead of mmddyyyy).
>      - Display tar exit codes when reporting errors.
>      - Don't send error messages to /dev/null, so we know what failed.
>      - Suppress useless tar "socket ignored" message.
> Thank you for considering this patch.

Thank you so much for doing this, this looks like a really useful

Reviewed-by: Andrew Bartlett <abartlet at samba.org>

Can I have a second reviewer from the team please?

For the future, one useful change might be to change the ldb.bak files
back into ldb files before or during archive creation, to make restore
easier.  Having a test for this somehow would also be really neat. 


Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

More information about the samba-technical mailing list