[PATCH] Re: samba_backup bug fix, error message enhancements, command line enhancement

Andreas Schneider asn at samba.org
Fri Oct 4 07:09:57 MDT 2013


On Tuesday 01 October 2013 09:58:20 Andrew Bartlett wrote:
> On Mon, 2013-09-30 at 13:34 -0700, Brian Martin wrote:
> > [snip]
> > 
> > > I would prefer the files in the backup could just be restored directly,
> > > so end in .ldb.
> > > 
> > >>   From the patch mechanics perspective, do I code this against the
> > >> 
> > >> current base code, against the code containing my prior patches, or
> > >> should I withdraw the prior patch and prepare a single new patch
> > >> containing the prior patches and this too?
> > > 
> > > Whichever you prefer.  Generally we like small patches that do one thing
> > > at a time, so building on top of this is quite fine.
> > 
> > [snip]
> > 
> > Attached is the patch you suggested.  Please let me know if there's
> > anything else I can do.
> 
> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
> 
> Can I get a second team reviewer for both patches?
> 

Reviewed-by: Andreas Schneider <asn at samba.org>

-- 
Andreas Schneider                   GPG-ID: F33E3FC6
Samba Team                             asn at samba.org
www.samba.org



More information about the samba-technical mailing list