SMB2/3 Performance

Stefan (metze) Metzmacher metze at samba.org
Fri Nov 22 06:51:05 MST 2013


Am 22.11.2013 14:45, schrieb David Disseldorp:
> On Wed, 20 Nov 2013 17:49:09 +0100
> "Stefan (metze) Metzmacher" <metze at samba.org> wrote:
> 
>> From df0f04036e4e2b30fa7f5dda1f968d20e83ad988 Mon Sep 17 00:00:00 2001
>> From: Stefan Metzmacher <metze at samba.org>
>> Date: Wed, 16 Oct 2013 09:15:12 +0200
>> Subject: [PATCH 4/6] s3:smb2_server: allocate smbd_smb2_request on
>>  talloc_tos()
>>
>> This matches the behavior for smb1 requests.
> 
> Is there any advantage, aside from smb1 uniformity?

Yes, one less malloc() per request, which costs a lot.

I'll add a comment to the commit message...

The aim is to do at most one malloc() per request.
I have plans to reclaim unused talloc_stackframe_pool() memory,
instead of doing one malloc() event loop, but that might come later.

metze



More information about the samba-technical mailing list