SMB2/3 Performance

David Disseldorp ddiss at suse.de
Fri Nov 22 06:45:35 MST 2013


On Wed, 20 Nov 2013 17:49:09 +0100
"Stefan (metze) Metzmacher" <metze at samba.org> wrote:

> From df0f04036e4e2b30fa7f5dda1f968d20e83ad988 Mon Sep 17 00:00:00 2001
> From: Stefan Metzmacher <metze at samba.org>
> Date: Wed, 16 Oct 2013 09:15:12 +0200
> Subject: [PATCH 4/6] s3:smb2_server: allocate smbd_smb2_request on
>  talloc_tos()
> 
> This matches the behavior for smb1 requests.

Is there any advantage, aside from smb1 uniformity?
I personally much prefer talloc_pool() preallocation with explicit
talloc_free(), rather than the garbage-collection style talloc_tos()
behaviour.

Cheers, David


More information about the samba-technical mailing list