[PATCH] Optimisation for readdir using fstatat.
Jeremy Allison
jra at samba.org
Tue May 28 18:23:50 MDT 2013
On Sat, May 25, 2013 at 09:13:48AM +0200, Stefan (metze) Metzmacher wrote:
> Hi Jeremy,
>
> > --- a/source3/wscript
> > +++ b/source3/wscript
> > @@ -452,6 +452,10 @@ return acl_get_perm_np(permset_d, perm);
> >
> > if conf.CHECK_FUNCS('dirfd'):
> > conf.DEFINE('HAVE_DIRFD_DECL', 1)
> > + conf.DEFINE('HAVE_DIRFD', 1)
> > +
> > + if conf.CHECK_FUNCS('fstatat'):
> > + conf.DEFINE('HAVE_fstatat', 1)
>
> Here's a typo HAVE_fstatat => HAVE_FSTATAT.
>
> But also notice that the additional conf.DEFINE() calls are not needed.
>
> conf.CHECK_FUNCS() calls conf.CHECK_FUNC() which uses define='HAVE_%s' %
> f.upper()
> as the default define.
Ok thanks ! I learn more about waf every day :-). I'll fix
and resubmit.
Jeremy.
More information about the samba-technical
mailing list