[PATCH] Optimisation for readdir using fstatat.

Stefan (metze) Metzmacher metze at samba.org
Sat May 25 01:13:48 MDT 2013


Hi Jeremy,

> --- a/source3/wscript
> +++ b/source3/wscript
> @@ -452,6 +452,10 @@ return acl_get_perm_np(permset_d, perm);
>  
>      if conf.CHECK_FUNCS('dirfd'):
>          conf.DEFINE('HAVE_DIRFD_DECL', 1)
> +        conf.DEFINE('HAVE_DIRFD', 1)
> +
> +    if conf.CHECK_FUNCS('fstatat'):
> +        conf.DEFINE('HAVE_fstatat', 1)

Here's a typo HAVE_fstatat => HAVE_FSTATAT.

But also notice that the additional conf.DEFINE() calls are not needed.

conf.CHECK_FUNCS() calls conf.CHECK_FUNC() which uses define='HAVE_%s' %
f.upper()
as the default define.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130525/9fdc4283/attachment.pgp>


More information about the samba-technical mailing list