[PATCH] Do not always regenerate version.h

Jeremy Allison jra at samba.org
Wed May 22 17:56:34 MDT 2013


On Thu, May 23, 2013 at 09:49:19AM +1000, Andrew Bartlett wrote:
> While searching to see if these always-regenerated file were causing a
> cascade of slowness hurting the null build, I fixed up version.h not to
> be regenerated.  
> 
> Waf is smart - the checksum of the regenerated file doesn't change,
> which is why this doesn't rebuild the whole of Samba, but I wondered if
> we could avoid even checking that.  
> 
> I think the patch is an improvement to correctness, but it doesn't seem
> to help performance (nor BTW does doing the same to build_options.c, as
> a test). 
> 
> Please review/push.
> 
> Thanks,
> 
> Andrew Bartlett

Andrew,

	You've been requested many times to add a Signed-off-by:
line to patches, and all other Team members (to my knowledge)
now do so.

I'm afraid I won't be reviewing/pushing any more of your patches
unless you adopt the convention that everyone else follows. At
this point it's a matter of good practice.

It's as simple as typing '-s' on the git command line when
committing the patch, so I really don't see your objection
to doing so.

Jeremy.


More information about the samba-technical mailing list