[PATCH] Do not always regenerate version.h

[Andrew Bartlett]

On Wed, 2013-05-22 at 16:56 -0700, Jeremy Allison wrote:
> On Thu, May 23, 2013 at 09:49:19AM +1000, Andrew Bartlett wrote:
> > While searching to see if these always-regenerated file were causing a
> > cascade of slowness hurting the null build, I fixed up version.h not to
> > be regenerated.  
> > 
> > Waf is smart - the checksum of the regenerated file doesn't change,
> > which is why this doesn't rebuild the whole of Samba, but I wondered if
> > we could avoid even checking that.  
> > 
> > I think the patch is an improvement to correctness, but it doesn't seem
> > to help performance (nor BTW does doing the same to build_options.c, as
> > a test). 
> > 
> > Please review/push.
> > 
> > Thanks,
> > 
> > Andrew Bartlett
> 
> Andrew,
> 
> 	You've been requested many times to add a Signed-off-by:
> line to patches, and all other Team members (to my knowledge)
> now do so.

I've explained that I don't like that there seems to be two different
meanings for Signed-off-by, one in the wiki (which on it's own would be
perfectly reasonable, if not very precise), and other very specific
meaning in https://www.samba.org/samba/devel/copyright-policy.html

> I'm afraid I won't be reviewing/pushing any more of your patches
> unless you adopt the convention that everyone else follows. At
> this point it's a matter of good practice.
> 
> It's as simple as typing '-s' on the git command line when
> committing the patch, so I really don't see your objection
> to doing so.

I'm seeking advise on the matter.

Andrew Bartlett
-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org