[PATCH] pyldb: decrement ref counters on py_results and quiet, warnings

Matthieu Patou mat at samba.org
Fri May 17 17:20:07 MDT 2013


On 05/17/2013 04:08 PM, Jelmer Vernooij wrote:
> On Fri, May 17, 2013 at 10:35:13AM -0700, Matthieu Patou wrote:
>> Hello,
>>
>> Can someone review this patch ?
>>
>> The problem is that the variable is not used so it raise a set but
>> not used warning, we can't just ignore the result otherwise we would
>> leak memory.
> You probably want Py_XDECREF(py_result), which is a noop if py_result is NULL.
Better?
Can I had your review ?

Matthieu.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-pyldb-decrement-ref-counters-on-py_results-and-quiet.patch
Type: text/x-diff
Size: 1036 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130517/4275b5a9/attachment.patch>


More information about the samba-technical mailing list