[PATCH] pyldb: decrement ref counters on py_results and quiet, warnings

Jelmer Vernooij jelmer at samba.org
Fri May 17 17:54:06 MDT 2013


On Fri, May 17, 2013 at 04:20:07PM -0700, Matthieu Patou wrote:
> On 05/17/2013 04:08 PM, Jelmer Vernooij wrote:
> >On Fri, May 17, 2013 at 10:35:13AM -0700, Matthieu Patou wrote:
> >>Hello,
> >>
> >>Can someone review this patch ?
> >>
> >>The problem is that the variable is not used so it raise a set but
> >>not used warning, we can't just ignore the result otherwise we would
> >>leak memory.
> >You probably want Py_XDECREF(py_result), which is a noop if py_result is NULL.
> Better?
> Can I had your review ?
Feel free to push with my Reviewed-By.

Cheers,

Jelmer


More information about the samba-technical mailing list