[PATCH] dsdb-drepl: create a new schedulable task for running pending operations

Matthieu Patou mat at samba.org
Wed May 15 05:53:50 MDT 2013


On 05/14/2013 10:28 PM, Stefan (metze) Metzmacher wrote:
> Hi Matthieu,
>
>> Please find attached a patch to create a new scdulable task designed to
>> run only pending operation instead of reruning all the operations.
> It's a bit strange to talk about a new 'task' to my this implied
> a new process with its own struct task_server instance.
>
> What about adding the new functions at the end of drepl_periodic.c?
> That file is not really large.
>
> In commit message we could say something like:
>
>    dsdb-drepl: add dreplsrv_pendingops_schedule()
>
>    So instead of running dreplsrv_periodic_schedule() when receiving a
>    DRS_REPLICA_SYNC request which will force the DC to look for changes
>    with all the DC it usually replicate to, we reduce it to the DC
>    specified in the DRS_REPLICA_SYNC request. It will allow also to do
> have the
>    correct options as set by the client who send the DRS_REPLICA_SYNC.
>
> The code itself looks good, thanks!
> metze
What about this version ?

Matthieu

-- 
Matthieu Patou
Samba Team
http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dsdb-drepl-create-a-new-schedulable-event-for-runnin.patch
Type: text/x-diff
Size: 4055 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130515/6f2f12bd/attachment.patch>


More information about the samba-technical mailing list