[PATCH] dsdb-drepl: create a new schedulable task for running pending operations

Stefan (metze) Metzmacher metze at samba.org
Tue May 14 23:28:04 MDT 2013


Hi Matthieu,

> Please find attached a patch to create a new scdulable task designed to
> run only pending operation instead of reruning all the operations.

It's a bit strange to talk about a new 'task' to my this implied
a new process with its own struct task_server instance.

What about adding the new functions at the end of drepl_periodic.c?
That file is not really large.

In commit message we could say something like:

  dsdb-drepl: add dreplsrv_pendingops_schedule()

  So instead of running dreplsrv_periodic_schedule() when receiving a
  DRS_REPLICA_SYNC request which will force the DC to look for changes
  with all the DC it usually replicate to, we reduce it to the DC
  specified in the DRS_REPLICA_SYNC request. It will allow also to do
have the
  correct options as set by the client who send the DRS_REPLICA_SYNC.

The code itself looks good, thanks!
metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 261 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130515/7117595a/attachment.pgp>


More information about the samba-technical mailing list