[PATCH 5/7] s3-param: Add lp_set_dos_charset().

[Andreas Schneider]

On Thursday 14 March 2013 16:51:35 Andrew Bartlett wrote:
> On Wed, 2013-03-13 at 13:44 +0100, Andreas Schneider wrote:
> > On Wednesday 13 March 2013 22:17:14 Andrew Bartlett wrote:
> > > > > What does this do that lp_set_cmdline("dos charset", name) doesn't
> > > > > do?
> > > > 
> > > > init_iconv();
> > > 
> > > I'm pretty sure that will be called.  lp_set_cmdline() calls the same
> > > things that an smb.conf setting calls, and that includes
> > > handle_dos_charset() (the special handler for this parameter).
> > 
> > I've changed it. See
> > 
> > https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/printing_mi
> > grate
> I assume you have changed it somewhere, but
> https://git.samba.org/?p=asn/samba.git;a=commitdiff;h=86273cb23c1b0e239b304a
> b058e0fe66d4ae9405 still has this function.

Sorry, I forgot to push. I've updated the branch and also added a torture 
test.


	-- andreas

-- 
Andreas Schneider                   GPG-ID: F33E3FC6
Samba Team                             asn at samba.org
www.samba.org