[PATCH 5/7] s3-param: Add lp_set_dos_charset().

Andrew Bartlett abartlet at samba.org
Wed Mar 13 23:51:35 MDT 2013


On Wed, 2013-03-13 at 13:44 +0100, Andreas Schneider wrote:
> On Wednesday 13 March 2013 22:17:14 Andrew Bartlett wrote:
> > > > What does this do that lp_set_cmdline("dos charset", name) doesn't do?
> > > 
> > > init_iconv();
> > 
> > I'm pretty sure that will be called.  lp_set_cmdline() calls the same
> > things that an smb.conf setting calls, and that includes
> > handle_dos_charset() (the special handler for this parameter).
> 
> I've changed it. See
> 
> https://git.samba.org/?p=asn/samba.git;a=shortlog;h=refs/heads/printing_migrate

I assume you have changed it somewhere, but
https://git.samba.org/?p=asn/samba.git;a=commitdiff;h=86273cb23c1b0e239b304ab058e0fe66d4ae9405 still has this function. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org




More information about the samba-technical mailing list