[PATCH] Fix for bug #9706 - Parameter is incorrect on Android

[Jeremy Allison]

On Tue, Mar 12, 2013 at 08:14:00AM +0100, Stefan (metze) Metzmacher wrote:
> Am 11.03.2013 22:54, schrieb Jeremy Allison:
> > On Mon, Mar 11, 2013 at 01:55:12PM -0700, Jeremy Allison wrote:
> >> We need to tweak the 'large read' detection code some more...
> > 
> > Ok, here's a version with the correct MS-doc reference
> > in the comment, and also a better order of tests in the
> > second part.
> > 
> > Please review (and test :-) and push if you're happy.
> 
> Can you write some tests which verifies both patches?

What shall we test here ? We need to verify we act
the same as Windows, so we'll need to find a way
to remove the sending "Samba" string in the client
libraries (or to explicitly ignore it in the server)
so we don't always fall into the "it's a Samba client,
look at the top bits' case.

That will take some time, and this is certainly
a blocker for 4.0.next (not working with Android
clients is a severe flaw).

IMHO the two extra tests we need are to ensure
that the top bits are ignored if :

a). We send 0xFFFF in the top word.
b). We don't negotiate CAP_LARGE_READX in the
sessionsetup.

Do you agree ?

Jeremy.