[PATCH] Fix for bug #9706 - Parameter is incorrect on Android

Jeremy Allison jra at samba.org
Tue Mar 12 10:43:21 MDT 2013


On Tue, Mar 12, 2013 at 09:24:40AM -0700, Jeremy Allison wrote:
> What shall we test here ? We need to verify we act
> the same as Windows, so we'll need to find a way
> to remove the sending "Samba" string in the client
> libraries (or to explicitly ignore it in the server)
> so we don't always fall into the "it's a Samba client,
> look at the top bits' case.

Aha ! Looks like I can do this by restricting the
protocol types request in smbXcli_negprot_send()
to use max and min protocols of PROTOCOL_NT1.

Shouldn't be too hard to add these then.

Updated patch including tests to follow. On
another note, I'm starting to think we shouldn't
look at lp_unix_extensions() in this code path
at all, as it really makes no difference in
how we should respond to a large read request.

The only things we should look at are the
0xFFFF value, the RA_SAMBA arch, and the
CAP_LARGE_READX negotiate.

Jeremy.


More information about the samba-technical mailing list