[PATCH] Implement machinepass= in 'net ads join'

[Andrew Bartlett]

On Fri, 2013-03-01 at 13:07 -0800, Jeremy Allison wrote:
> On Thu, Feb 28, 2013 at 11:31:17PM +1100, Andrew Bartlett wrote:
> > G'day,
> > 
> > These patches add (and add tests for) a new machinepass= option for 'net
> > ads join'. 
> > 
> > This makes this match 'samba-tool domain join'.  For master and 4.0,
> > this is not strictly required, as a workaround is to call 'samba-tool
> > domain join'.  However, I've been asked to backport this to 3.6, for
> > Univention at least, and I think having the capability is a reasonable
> > addition in any case.
> > 
> > The only thing is that in all these tools, we don't try and wipe the
> > password from the command line, but I'm not worried by this. 
> > 
> > The first patch is needed because the included tests showed that we in
> > fact did not correct set the machine password in the testsuite's calls
> > to 'samba-tool', so adding tests here has already been a worthwhile
> > exercise.  
> > 
> > Please review/push/comment.  
> 
> Having said "LGTM" and looked at the code it looks really
> obvious, but I can't push as the new test file :
> 
> script/tests/test_smbclient_specified_machine_auth.sh
> 
> isn't in the patchset (so my make test failed :-).
> 
> Can you add it and re-submit ?

Sorry about that.

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-selftest-Fix-specification-of-machinepass-to-actuall.patch
Type: text/x-patch
Size: 3402 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130302/798433c8/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-net-ads-join-Add-support-for-specifying-the-machine-.patch
Type: text/x-patch
Size: 3608 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130302/798433c8/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-selftest-Show-that-the-machinepass-and-machinepass-j.patch
Type: text/x-patch
Size: 3416 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130302/798433c8/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-docs-Add-documentation-for-osName-and-osVer.patch
Type: text/x-patch
Size: 1346 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130302/798433c8/attachment-0003.bin>