[PATCH] Implement machinepass= in 'net ads join'
Jeremy Allison
jra at samba.org
Fri Mar 1 14:07:20 MST 2013
On Thu, Feb 28, 2013 at 11:31:17PM +1100, Andrew Bartlett wrote:
> G'day,
>
> These patches add (and add tests for) a new machinepass= option for 'net
> ads join'.
>
> This makes this match 'samba-tool domain join'. For master and 4.0,
> this is not strictly required, as a workaround is to call 'samba-tool
> domain join'. However, I've been asked to backport this to 3.6, for
> Univention at least, and I think having the capability is a reasonable
> addition in any case.
>
> The only thing is that in all these tools, we don't try and wipe the
> password from the command line, but I'm not worried by this.
>
> The first patch is needed because the included tests showed that we in
> fact did not correct set the machine password in the testsuite's calls
> to 'samba-tool', so adding tests here has already been a worthwhile
> exercise.
>
> Please review/push/comment.
Having said "LGTM" and looked at the code it looks really
obvious, but I can't push as the new test file :
script/tests/test_smbclient_specified_machine_auth.sh
isn't in the patchset (so my make test failed :-).
Can you add it and re-submit ?
Thanks,
Jeremy.
More information about the samba-technical
mailing list