Rusty Russell rusty at rustcorp.com.au
Wed Jun 5 20:54:17 MDT 2013

Volker Lendecke <Volker.Lendecke at SerNet.DE> writes:
> On Wed, Jun 05, 2013 at 04:57:32PM +0930, Rusty Russell wrote:
>> Volker Lendecke <Volker.Lendecke at SerNet.DE> writes:
>> > Hi, Rusty!
>> >
>> > With f6eb187fdab you added $SUBJECT. Right now I don't see a
>> > user of this API. The attached patch removes the code. Okay?
>> >
>> > If such a feature is required, I would rather implement a
>> > fetch_locked_send/recv pair. You can do the timeout variant
>> > with tevent_req_send_endtime and a nested event context if
>> > required.
>> OK, looking through my pile of convert-to-dbwrap patches (many of which
>> are obsolete, as they were done so long ago) I used this in
>> source3/lib/eventlog/eventlog.c and source3/printing/printing.c.
>> These both still use *timeout functions, though I think you're right
>> that it'd be better if they didn't.
>> I continue my slow sweep though Samba, converting databases to be
>> ntdb-capable (via dbwrap).  I can simply leave these until last.
> So you are fine to remove the timeout wrapper?

Sure; I'll reopen this thread when I get to those conversions.


More information about the samba-technical mailing list