[patch] cifs: arrays are never NULL
Dan Carpenter
dan.carpenter at oracle.com
Sun Jul 28 14:26:09 MDT 2013
It causes a static analysis warning when check to see if an array is
NULL. I have removed the check.
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
---
Or perhaps the intent was to check
} else if (strlen(ses->serverName)) {
I am not very familiar with this code.
diff --git a/fs/cifs/cifsencrypt.c b/fs/cifs/cifsencrypt.c
index bb84d7c..16f4908 100644
--- a/fs/cifs/cifsencrypt.c
+++ b/fs/cifs/cifsencrypt.c
@@ -514,7 +514,7 @@ static int calc_ntlmv2_hash(struct cifs_ses *ses, char *ntlmv2_hash,
__func__);
return rc;
}
- } else if (ses->serverName) {
+ } else {
len = strlen(ses->serverName);
server = kmalloc(2 + (len * 2), GFP_KERNEL);
More information about the samba-technical
mailing list