[PATCH 3/7] torture: Don't segfault in smb2.session on error.

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Jul 3 09:54:14 MDT 2013

On Wed, Jul 03, 2013 at 08:51:20AM -0700, Jeremy Allison wrote:
> On Wed, Jul 03, 2013 at 03:58:59PM +0200, Volker Lendecke wrote:
> > 
> > In particular the one that was discussed here already I
> > would say that initializing the whole buffer would be
> > unnecessary and would hide potential bugs in the smbcli_read
> > call from valgrind. For many variables it makes sense to be
> > initializes, but by far not for all, so a catch-all law to
> > make everything initialized is going to far IMO. But that's
> > just my 2ct.
> Well I'm taking about initializing variables, not buffers.
> I agree that's usually overkill and can hide valgrind bugs.

Well, in this case "buf" *is* a variable. An array, but
still a local variable. Where do you draw the line?


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list