[PATCH 3/7] torture: Don't segfault in smb2.session on error.

Jeremy Allison jra at samba.org
Wed Jul 3 09:51:20 MDT 2013

On Wed, Jul 03, 2013 at 03:58:59PM +0200, Volker Lendecke wrote:
> In particular the one that was discussed here already I
> would say that initializing the whole buffer would be
> unnecessary and would hide potential bugs in the smbcli_read
> call from valgrind. For many variables it makes sense to be
> initializes, but by far not for all, so a catch-all law to
> make everything initialized is going to far IMO. But that's
> just my 2ct.

Well I'm taking about initializing variables, not buffers.
I agree that's usually overkill and can hide valgrind bugs.


More information about the samba-technical mailing list