[PATCH 3/7] torture: Don't segfault in smb2.session on error.
asn at samba.org
Tue Jul 2 14:42:06 MDT 2013
On Tuesday 02 July 2013 12:26:59 Jeremy Allison wrote:
> On Mon, Jul 01, 2013 at 01:02:44PM +0200, Andreas Schneider wrote:
> > Signed-off-by: Andreas Schneider <asn at samba.org>
> > ---
> > source4/torture/smb2/session.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > diff --git a/source4/torture/smb2/session.c
> > b/source4/torture/smb2/session.c index 9592b5e..6901f47 100644
> > --- a/source4/torture/smb2/session.c
> > +++ b/source4/torture/smb2/session.c
> > @@ -863,7 +863,7 @@ static bool test_session_expire1(struct
> > torture_context *tctx)>
> > const char *host = torture_setting_string(tctx, "host", NULL);
> > const char *share = torture_setting_string(tctx, "share", NULL);
> > struct cli_credentials *credentials = cmdline_credentials;
> > - struct smb2_tree *tree;
> > + struct smb2_tree *tree = NULL;
> > enum credentials_use_kerberos use_kerberos;
> > char fname;
> > struct smb2_handle _h1;
> I'm reviewing these..
> FYI. Most of these come from failing to initialize auto
> variables on declaration.
I think if you have a variable is which passed by reference to a function and
is an out (result) variable it should be initialized by default. Especially if
you use a destructor (goto done).
Andreas Schneider GPG-ID: F33E3FC6
Samba Team asn at samba.org
More information about the samba-technical