[PATCH 3/7] torture: Don't segfault in smb2.session on error.

[Jeremy Allison]

On Mon, Jul 01, 2013 at 01:02:44PM +0200, Andreas Schneider wrote:
> Signed-off-by: Andreas Schneider <asn at samba.org>
> ---
>  source4/torture/smb2/session.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/source4/torture/smb2/session.c b/source4/torture/smb2/session.c
> index 9592b5e..6901f47 100644
> --- a/source4/torture/smb2/session.c
> +++ b/source4/torture/smb2/session.c
> @@ -863,7 +863,7 @@ static bool test_session_expire1(struct torture_context *tctx)
>  	const char *host = torture_setting_string(tctx, "host", NULL);
>  	const char *share = torture_setting_string(tctx, "share", NULL);
>  	struct cli_credentials *credentials = cmdline_credentials;
> -	struct smb2_tree *tree;
> +	struct smb2_tree *tree = NULL;
>  	enum credentials_use_kerberos use_kerberos;
>  	char fname[256];
>  	struct smb2_handle _h1;
> -- 
> 1.8.3.1

I'm reviewing these..

FYI. Most of these come from failing to initialize auto
variables on declaration.

Personally I've started a policy in my own code of *always*
initializing auto variables on declaration to a "safe"
default.

Yeah, it's slightly less efficient but it prevents bugs.

Should this be part of our coding standards ?

Please discuss... :-)

(Throws bomb and stands well back).

Jeremy.