[PATCH] Do not force which perl to use for pod2man

Michael Adam obnox at samba.org
Wed Feb 27 16:37:07 MST 2013


Builds fine on a SLES11 system I have available
and seems the right thing to do - pushed to master.

On 2013-02-28 at 10:03 +1100, Andrew Bartlett wrote:
> Attached is a revised patch with a commit message indicating the history
> here, to help others who may come across this again.
> 
> Andrew Bartlett
> -- 
> Andrew Bartlett                                http://samba.org/~abartlet/
> Authentication Developer, Samba Team           http://samba.org
> 

> >From 56207cd13964085daedcf618a3ebc9cef8767190 Mon Sep 17 00:00:00 2001
> From: Andrew Bartlett <abartlet at samba.org>
> Date: Fri, 8 Feb 2013 09:12:20 +1100
> Subject: [PATCH] build: Do not force a specific perl from ${PERL} when
>  running pod2man
> 
> pod2man should have the right #!/usr/bin/perl line already, and forcing it may
> cause us to use the wrong perl.
> 
> Essentially treat this like any other system binary, rather than forcing
> it to use the first perl we found.
> 
> This essentially reverts e80f576db66ad04592ac436ed74ceb9b96452060.
> Current SLES11 does not seem to have the issue this was added to
> address.
> 
> Andrew Bartlett
> ---
>  pidl/wscript | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/pidl/wscript b/pidl/wscript
> index e60ca20..7a25734 100644
> --- a/pidl/wscript
> +++ b/pidl/wscript
> @@ -49,7 +49,7 @@ def build(bld):
>      bld.SET_BUILD_GROUP('final')
>      if 'POD2MAN' in bld.env and bld.env['POD2MAN'] != '':
>          for src, manpage in pidl_manpages.iteritems():
> -            bld(rule='${PERL} ${POD2MAN} -c "Samba Documentation" ${SRC} ${TGT}',
> +            bld(rule='${POD2MAN} -c "Samba Documentation" ${SRC} ${TGT}',
>                  shell=True,
>                  source=src,
>                  install_path=os.path.dirname(bld.EXPAND_VARIABLES('${MANDIR}/'+manpage)),
> -- 
> 1.7.11.7
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 206 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130228/b7bd9074/attachment.pgp>


More information about the samba-technical mailing list