Some patches that help Samba respond more like Windows (based on smbtorture tests run against Server 2008

Richard Sharpe realrichardsharpe at gmail.com
Fri Feb 8 10:51:19 MST 2013


OK, here is a better patch. I will change add a signed-off-by soon:

diff --git a/source3/include/smb.h b/source3/include/smb.h
index a163e9e..097d7ea 100644
--- a/source3/include/smb.h
+++ b/source3/include/smb.h
@@ -482,7 +482,8 @@ Offset  Data                        length.

 #define NTCREATEX_OPTIONS_MUST_IGNORE_MASK      (0x008F0480)

-#define NTCREATEX_OPTIONS_INVALID_PARAM_MASK    (0xFF100030)
+#define NTCREATEX_OPTIONS_INVALID_PARAM_MASK    (0xFF000030)
+#define NTCREATEX_OPTIONS_NOT_SUPPORTED_MASK   (0x00100080)

 /*
  * Private create options used by the ntcreatex processing code. From Samba4.
diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index be8d31b..92533ab 100644
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -3683,7 +3683,7 @@ static NTSTATUS
create_file_unixpath(connection_struct *conn,
                  (unsigned int)private_flags,
                  ea_list, sd, smb_fname_str_dbg(smb_fname)));

-       if (create_options & FILE_OPEN_BY_FILE_ID) {
+       if (create_options & NTCREATEX_OPTIONS_NOT_SUPPORTED_MASK) {
                status = NT_STATUS_NOT_SUPPORTED;
                goto fail;
        }

This is against master.

-- 
Regards,
Richard Sharpe
(何以解憂?唯有杜康。--曹操)


More information about the samba-technical mailing list