Patch: Fix the smbtorture smb2.compound request to not fail on Win2K08, Win7 and Samba3 responses

[Jeremy Allison]

On Fri, Feb 15, 2013 at 04:15:05PM -0800, Richard Sharpe wrote:
> On Fri, Feb 15, 2013 at 4:07 PM, Richard Sharpe
> <realrichardsharpe at gmail.com> wrote:
> > On Fri, Feb 15, 2013 at 3:24 PM, Jeremy Allison <jra at samba.org> wrote:
> >> On Sun, Feb 03, 2013 at 09:43:09AM -0800, Richard Sharpe wrote:
> >>> On Thu, Jan 31, 2013 at 11:39 PM, Stefan (metze) Metzmacher
> >>> <metze at samba.org> wrote:
> >>> > Hi Richard,
> >>> >
> >>> >> Attached is a patch for this. If someone thinks it is OK, please
> >>> >> review and push to autobuild.
> >>> >
> >>> > Does this pass against windows 2012?
> >>>
> >>> Interesting. Based on the behavior of the Windows 8 Beta, they have
> >>> changed things between Server 2008 and Windows 8.
> >>
> >> Can you tell me exactly what changed here ?
> >
> > I Have an outstanding query with DocHelp about the fact that actual
> > W2K12 behavior does not conform to the spec (including the product
> > notes.)
> >
> > Attached are two captures that show the changes:
> >
> > Frames 15 and 16 on w2k08-smb2-compound-invalid4.pcap show what W2K08
> > does, while frames 15 and 16 on
> > w2k12-smb2-compound-invalid4-smaller.pcap show how W2K12 behaves, if I
> > have the right problem.
> >
> > If not I will have to check it out over the weekend and get you captures.
> 
> OK, I got that wrong. W2K12 has indeed changed its behavior, and now
> returns STATUS_FILE_CLOSED when W2K08 returned
> STATUS_INVALID_PARAMETER, but I can see no violation of the spec or
> the product notes in either behavior.
> 
> I can send you captures of both if you want.

Yes please ! I think standardizing on W2K12 might be
the right thing to do.

Jeremy.