[PATCH] Fix classicupgrade error message (was Re: [Samba] Classicupgrade not work)

[Jonis Maurin Ceará]

Tks Andrew!!
Changes that you've made worked for that problem, but now i got a new
one....and in this one i'm really stuck! Not even a field name.

This is my log (log level 12):

element 32 -> now SET
element 33 -> now SET
ldapsam_get_account_policy: got valid value from cache
element 19 -> now SET
element 15 -> now SET
element 16 -> now SET
attribute sambaBadPasswordCount does not exist
attribute sambaBadPasswordTime does not exist
attribute sambaLogonHours does not exist
Adding cache entry with key =
IDMAP/SID2XID/S-1-5-21-511255529-1355219746-1726288727-3659 and
timeout = Mon Feb 18 22:58:35 2013
 (604800 seconds ahead)
Adding cache entry with key = IDMAP/UID2SID/1341 and timeout = Mon Feb
18 22:58:35 2013
 (604800 seconds ahead)
gid 1003 -> sid S-1-5-21-511255529-1355219746-1726288727-3007
gid 1003 -> sid S-1-5-21-511255529-1355219746-1726288727-3007
do lookup_sid(S-1-5-21-511255529-1355219746-1726288727-3007) for group
of user lesley
lookup_sid called for SID 'S-1-5-21-511255529-1355219746-1726288727-3007'
Accepting SID S-1-5-21-511255529-1355219746-1726288727 in level 1
lookup_rids called for domain sid 'S-1-5-21-511255529-1355219746-1726288727'
smbldap_search_ext: base => [ou=Users,dc=fearp,dc=usp,dc=br], filter
=> [(&(objectClass=sambaSamAccount)(|(sambaSid=S-1-5-21-511255529-1355219746-1726288727-3007)))],
scope => [2]
smbldap_open: already connected to the LDAP server
smbldap_search_ext: base => [dc=fearp,dc=usp,dc=br], filter =>
[(&(objectClass=sambaGroupMapping)(|(sambaSid=S-1-5-21-511255529-1355219746-1726288727-3007)))],
scope => [2]
smbldap_open: already connected to the LDAP server
Sid S-1-5-21-511255529-1355219746-1726288727-3007 -> FEARP\pgrd(2)
Did not store value for
IDMAP/SID2XID/S-1-5-21-511255529-1355219746-1726288727-3007, we
already got it
Did not store value for IDMAP/GID2SID/1003, we already got it
Looking up login cache for user lesley
No cache entry found
No cache entry, bad count = 0, bad time = 0
element 35 -> now CHANGED
ERROR(<type 'exceptions.TypeError'>): uncaught exception - %X format:
a number is required, not str
  File "/usr/local/samba/lib/python2.7/site-packages/samba/netcmd/__init__.py",
line 175, in _run
    return self.run(*args, **kwargs)
  File "/usr/local/samba/lib/python2.7/site-packages/samba/netcmd/domain.py",
line 1318, in run
    useeadb=eadb, dns_backend=dns_backend, use_ntvfs=use_ntvfs)
  File "/usr/local/samba/lib/python2.7/site-packages/samba/upgrade.py",
line 723, in upgrade_from_samba3
    samr.ACB_NORMAL, samr.ACB_WSTRUST, samr.ACB_SVRTRUST, samr.ACB_DOMTRUST))
The connection to the LDAP server was closed


2013/2/11 Andrew Bartlett <abartlet at samba.org>:
> On Mon, 2013-02-11 at 10:33 -0200, Jonis Maurin Ceará wrote:
>> I'm trying to convert my samba3  domain to samba4 AD with samba-tool,
>> but i'm getting an error and i can' t find anything about it on
>> google.
>>
>> I've enabled the log level 4 on smb.conf and here's what i got:
>>
>> Home server: PANDORA
>> init_sam_from_ldap: Entry found for user: DIRET-ESTAG$
>> Home server: PANDORA
>> init_sam_from_ldap: Entry found for user: dsegato
>> Home server: PANDORA
>> init_sam_from_ldap: Entry found for user: lesley
>> Home server: PANDORA
>> ERROR(<type 'exceptions.AttributeError'>): uncaught exception -
>> 'passdb.Samu' object has no attribute 'acct_flags'
>>   File "/usr/local/samba/lib64/python2.6/site-packages/samba/netcmd/__init__.py",
>> line 175, in _run
>>     return self.run(*args, **kwargs)
>>   File "/usr/local/samba/lib64/python2.6/site-packages/samba/netcmd/domain.py",
>> line 1318, in run
>>     useeadb=eadb, dns_backend=dns_backend, use_ntvfs=use_ntvfs)
>>   File "/usr/local/samba/lib64/python2.6/site-packages/samba/upgrade.py",
>> line 722, in upgrade_from_samba3
>>     % (user.acct_flags, username,
>> [
>>
>>
>> I've copied my .tdb files to a new test server.....also, i'm using
>> ldap backend on s3.
>
> I do apologise, there is an error in the classicupgrade script which
> means that instead of printing an informative error, we print this
> backtrace.
>
> I also attach another fix I've had in my local tree for a while, to fix
> the error when we can't find the LDAP secrets.
>
> Please check this improves the error, and then if someone could review
> and/or push this to master I would appreciate it.
>
> Thanks,
>
> Andrew Bartlett
>
> --
> Andrew Bartlett                                http://samba.org/~abartlet/
> Authentication Developer, Samba Team           http://samba.org
>