[PATCH] Fix classicupgrade error message (was Re: [Samba] Classicupgrade not work)

[Andrew Bartlett]

On Mon, 2013-02-11 at 10:33 -0200, Jonis Maurin Ceará wrote:
> I'm trying to convert my samba3  domain to samba4 AD with samba-tool,
> but i'm getting an error and i can' t find anything about it on
> google.
> 
> I've enabled the log level 4 on smb.conf and here's what i got:
> 
> Home server: PANDORA
> init_sam_from_ldap: Entry found for user: DIRET-ESTAG$
> Home server: PANDORA
> init_sam_from_ldap: Entry found for user: dsegato
> Home server: PANDORA
> init_sam_from_ldap: Entry found for user: lesley
> Home server: PANDORA
> ERROR(<type 'exceptions.AttributeError'>): uncaught exception -
> 'passdb.Samu' object has no attribute 'acct_flags'
>   File "/usr/local/samba/lib64/python2.6/site-packages/samba/netcmd/__init__.py",
> line 175, in _run
>     return self.run(*args, **kwargs)
>   File "/usr/local/samba/lib64/python2.6/site-packages/samba/netcmd/domain.py",
> line 1318, in run
>     useeadb=eadb, dns_backend=dns_backend, use_ntvfs=use_ntvfs)
>   File "/usr/local/samba/lib64/python2.6/site-packages/samba/upgrade.py",
> line 722, in upgrade_from_samba3
>     % (user.acct_flags, username,
> [
> 
> 
> I've copied my .tdb files to a new test server.....also, i'm using
> ldap backend on s3.

I do apologise, there is an error in the classicupgrade script which
means that instead of printing an informative error, we print this
backtrace.  

I also attach another fix I've had in my local tree for a while, to fix
the error when we can't find the LDAP secrets. 

Please check this improves the error, and then if someone could review
and/or push this to master I would appreciate it.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-samba-tool-domain-classicupgrade-Fix-typo-in-error-p.patch
Type: text/x-patch
Size: 1049 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130212/46676bf3/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-samba-tool-domain-classicupgrade-Print-a-better-erro.patch
Type: text/x-patch
Size: 1357 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130212/46676bf3/attachment-0001.bin>