[PATCH] smbd: Revert a93f9c3

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Aug 23 08:19:42 MDT 2013


Hi!

The attached patch should solve some of the problems people
have seen with regards to ACLs. This is new code that is
supposed to solve INFO_LENGTH_MISMATCH vs BUFFER_OVERFLOW
problems. It turns out that there's a bit more work to do in
this area. I am working on this right now.

This is an emergency patch for the people who want ACLs to
work quickly. The proper patch will follow next week.

This is not necessarily for upstream, as it breaks some
other cases again.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
From 558123a425881e7473914859af2e1f4d6280db12 Mon Sep 17 00:00:00 2001
From: Volker Lendecke <vl at samba.org>
Date: Fri, 23 Aug 2013 14:23:42 +0200
Subject: [PATCH] smbd: Revert a93f9c3

This needs a bit more thought. There's NT_STATUS_INFO_LENGTH_MISMATCH,
BUFFER_OVERFLOW and BUFFER_TOO_SMALL. More work to come.

Signed-off-by: Volker Lendecke <vl at samba.org>
---
 source3/smbd/smb2_getinfo.c |    5 -----
 1 file changed, 5 deletions(-)

diff --git a/source3/smbd/smb2_getinfo.c b/source3/smbd/smb2_getinfo.c
index 7a41b19..dfee50d 100644
--- a/source3/smbd/smb2_getinfo.c
+++ b/source3/smbd/smb2_getinfo.c
@@ -504,11 +504,6 @@ static struct tevent_req *smbd_smb2_getinfo_send(TALLOC_CTX *mem_ctx,
 		return tevent_req_post(req, ev);
 	}
 
-	if (state->out_output_buffer.length > in_output_buffer_length) {
-		tevent_req_nterror(req, NT_STATUS_INFO_LENGTH_MISMATCH);
-		return tevent_req_post(req, ev);
-	}
-
 	state->status = status;
 	tevent_req_done(req);
 	return tevent_req_post(req, ev);
-- 
1.7.9.5



More information about the samba-technical mailing list