[PATCH v4] vfs_glusterfs: Implement proper mashalling/unmarshalling of ACLs

[Christopher R. Hertel]

This is something we can look at as a longer-term solution, but we are also
considering adding a get/set ACL interface to the Gluster API.  There's some
debate within the Gluster dev community regarding where in the stack the API
belongs (since libacl lives above file systems and POSIX ACLs are actually
stored as EAs).

In the mean time, we would like to get this just plain working.  :)

So, following some additional review, we will likely go with Avati's patch
for now.  We already have a backlog of improvements for the module queued up
for "the long term".

Chris -)-----

On 08/12/2013 12:23 AM, Andrew Bartlett wrote:
> On Sun, 2013-08-11 at 15:59 -0400, Anand Avati wrote:
>> Use the primitives available in Samba byteorder.h for implementing
>> proper (un)marshalling of ACL xattrs.
> 
> I'll preface this by saying I know how painful it is when every man and
> his dog has a different view on how something should be implemented, but
> anyway:
> 
> I think this would be better done in IDL.  In general, Samba has moved
> from hand-marshalling to IDL for everything that isn't totally silly to
> do that way (and even then, we fit those into IDL most of the time). 
> 
> Could you try adding this to smb_acl.idl instead, and then using the
> generated the pull/push functions?
> 
> This is much less error prone than hand-marshaling, and comes with free
> pretty-printers and the ability to trivially manipulate the objects in
> python, if you ever need that. 
> 
> Thanks,
> 
> Andrew Bartlett
> 

-- 
Christopher R. Hertel -)-----               Samba Geek at Red Hat Linux
"Implementing CIFS - the Common Internet FileSystem"   ISBN: 013047116X