[PATCH v4] vfs_glusterfs: Implement proper mashalling/unmarshalling of ACLs

[Andrew Bartlett]

On Sun, 2013-08-11 at 15:59 -0400, Anand Avati wrote:
> Use the primitives available in Samba byteorder.h for implementing
> proper (un)marshalling of ACL xattrs.

I'll preface this by saying I know how painful it is when every man and
his dog has a different view on how something should be implemented, but
anyway:

I think this would be better done in IDL.  In general, Samba has moved
from hand-marshalling to IDL for everything that isn't totally silly to
do that way (and even then, we fit those into IDL most of the time). 

Could you try adding this to smb_acl.idl instead, and then using the
generated the pull/push functions?

This is much less error prone than hand-marshaling, and comes with free
pretty-printers and the ability to trivially manipulate the objects in
python, if you ever need that. 

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org
Samba Developer, Catalyst IT                   http://catalyst.net.nz