[PATCH] s3 - Add integer wrap protection when manipulating a client-supplied value.

David Disseldorp ddiss at suse.de
Sun Aug 4 07:03:33 MDT 2013


On Fri, 2 Aug 2013 17:13:34 -0700
Jeremy Allison <jra at samba.org> wrote:

> Ensure we can never integer wrap when working on client-supplied max_data_bytes.
> 
> This would only be possible with SMB2, and is already checked in the upper
> SMB2 layers, but it really doesn't hurt to have these extra checks at time
> of use also.
> 
> I noticed this when reviewing Ralph's patch, and thought I might as well
> tidy this up to ensure we can never have any issues here.

Looks fine Jeremy. Pushed to autobuild.

Cheers, David


More information about the samba-technical mailing list