[PATCH] s3 - Add integer wrap protection when manipulating a client-supplied value.
Volker Lendecke
Volker.Lendecke at SerNet.DE
Sat Aug 3 11:20:34 MDT 2013
On Fri, Aug 02, 2013 at 05:13:34PM -0700, Jeremy Allison wrote:
> Ensure we can never integer wrap when working on client-supplied max_data_bytes.
>
> This would only be possible with SMB2, and is already checked in the upper
> SMB2 layers, but it really doesn't hurt to have these extra checks at time
> of use also.
>
> I noticed this when reviewing Ralph's patch, and thought I might as well
> tidy this up to ensure we can never have any issues here.
Reviewed-by me.
We really need to convert the lower-level routines from
malloc to talloc.
Volker
--
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical
mailing list