[PATCH] Add tests for our NFSv4 ACL code

Abhidnya S Joshi achirmul at in.ibm.com
Wed Apr 24 06:25:55 MDT 2013

Hi Andrew,

Thanks for the review comments. While I take care of these, I would like 
to have one more test which checks inheritance for nfs4:mode 
specialcreator. This test fails currently for mode special and would pass 
with bug 9467 fix. 

I have used --extra-user torture option to test correct inheritance and 
avoid use of any well-knowns/builtins to avoid any further different 
failures other than basic inheritance. However I am not sure if this will 
work in selftest environment. Please let me know your views on use of 
--extra-user option. (Existing inheritance test tries to test multiple 
things except the behavior which new test checks)

Thanks and Regards
Abhidnya Joshi

From:   Andrew Bartlett <abartlet at samba.org>
To:     Abhidnya S Joshi/India/IBM at IBMIN, 
Cc:     samba-technical at lists.samba.org, jra at samba.org
Date:   04/24/2013 07:56 AM
Subject:        Re: [PATCH] Add tests for our NFSv4 ACL code

On Mon, 2013-04-22 at 15:25 +0530, Abhidnya S Joshi wrote:
> Hi Andrew, Alexander,
> To test this NFS4 ACL work, I have added 2 tests to check inheritance of 

> creator owner and creator group. Primary aim is to test Samba bug 9467.
> These two tests basically check if the creator owner/group SID gets 
> interpreted and applied correctly upon inheritance. Please review the 
> patch

These look OK.  Some small details:
 - Please check some of the indentation against README.Coding.  ie, the
indentation of the 'done:' label while clearer, doesn't look correct, we
normally don't indent these.

 - The knownfail entries you added:

don't match the failing test:

can you make sure a 'make test TESTS=raw.acls' and then full 'make test'
run passes on a top level build?

That said, it looks like we are getting closer to being able to get the
9467 patch merged!

I've had an issue raised with me that manually editing ACLs that have a
'creator group' element in them fails, but I've not yet had a chance to
reproduce that.  I will however want to sort that out one way or the
other before I merge the 9467 changes on which this patch depends. 


Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-4-smbtorture-Test-inheritance-for-specialcreator-mod.patch
Type: application/octet-stream
Size: 6400 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20130424/53da3413/attachment.obj>

More information about the samba-technical mailing list