[PATCH] Add tests for our NFSv4 ACL code

Andrew Bartlett abartlet at samba.org
Tue Apr 23 20:28:07 MDT 2013

On Mon, 2013-04-22 at 15:25 +0530, Abhidnya S Joshi wrote:
> Hi Andrew, Alexander,
> To test this NFS4 ACL work, I have added 2 tests to check inheritance of 
> creator owner and creator group. Primary aim is to test Samba bug 9467.
> These two tests basically check if the creator owner/group SID gets 
> interpreted and applied correctly upon inheritance. Please review the 
> patch

These look OK.  Some small details:
 - Please check some of the indentation against README.Coding.  ie, the
indentation of the 'done:' label while clearer, doesn't look correct, we
normally don't indent these.

 - The knownfail entries you added:

don't match the failing test:

can you make sure a 'make test TESTS=raw.acls' and then full 'make test'
run passes on a top level build?

That said, it looks like we are getting closer to being able to get the
9467 patch merged!

I've had an issue raised with me that manually editing ACLs that have a
'creator group' element in them fails, but I've not yet had a chance to
reproduce that.  I will however want to sort that out one way or the
other before I merge the 9467 changes on which this patch depends. 


Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

More information about the samba-technical mailing list