[PATCH] Raise minimum python version to 2.5

[Matthieu Patou]

On 04/09/2013 09:06 AM, Andrew Bartlett wrote:
> On Tue, 2013-04-09 at 00:18 -0700, Matthieu Patou wrote:
>> On 04/08/2013 02:04 AM, Andrew Bartlett wrote:
>>> The attached patch officially raises our minimum python version to 2.5
>>> for the waf Samba build.  As I mention in the patch, RHEL5 has a
>>> python26 package, and python 2.4 is very old these days.
>>>
>>> Apply on top of my previous patch.  Intended for master at this stage
>>> (no need to change this for 4.0, but it would avoid the issue with
>>> samba-tool in the AD DC build needing python 2.5).
>>>
>> I'm not against but what are the features from 2.5 that we missed so far ?
> The feature is the epilog argument to OptionsParser
>
> https://lists.samba.org/archive/samba/2012-December/170290.html
>
> and having to have this at the top of all our glue layers (eg
> source4/dsdb/pydsdb.c):
>
> /* There's no Py_ssize_t in 2.4, apparently */
> #if PY_MAJOR_VERSION == 2 && PY_MINOR_VERSION < 5
> typedef int Py_ssize_t;
> typedef inquiry lenfunc;
> typedef intargfunc ssizeargfunc;
> #endif
>
> Rather than continue to work around Python 2.4, I just want to require
> 2.5.  The reason we set the bar at 2.4 was for RHEL5, where I wasn't
> previously aware of the python26 package.
Ok seems a good idea for me then, I'll have a deeper look at your patch 
but at first glance it looked ok.

Matthieu.