[PATCH] Raise minimum python version to 2.5
abartlet at samba.org
Tue Apr 9 10:06:11 MDT 2013
On Tue, 2013-04-09 at 00:18 -0700, Matthieu Patou wrote:
> On 04/08/2013 02:04 AM, Andrew Bartlett wrote:
> > The attached patch officially raises our minimum python version to 2.5
> > for the waf Samba build. As I mention in the patch, RHEL5 has a
> > python26 package, and python 2.4 is very old these days.
> > Apply on top of my previous patch. Intended for master at this stage
> > (no need to change this for 4.0, but it would avoid the issue with
> > samba-tool in the AD DC build needing python 2.5).
> I'm not against but what are the features from 2.5 that we missed so far ?
The feature is the epilog argument to OptionsParser
and having to have this at the top of all our glue layers (eg
/* There's no Py_ssize_t in 2.4, apparently */
#if PY_MAJOR_VERSION == 2 && PY_MINOR_VERSION < 5
typedef int Py_ssize_t;
typedef inquiry lenfunc;
typedef intargfunc ssizeargfunc;
Rather than continue to work around Python 2.4, I just want to require
2.5. The reason we set the bar at 2.4 was for RHEL5, where I wasn't
previously aware of the python26 package.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
More information about the samba-technical