[PATCH][WIP] Make vfs_acl_xattr use hash of the posix ACL

Andrew Bartlett abartlet at samba.org
Wed Oct 31 16:08:43 MDT 2012

On Wed, 2012-10-31 at 22:56 +0100, Christian Ambach wrote:
> On 10/31/2012 02:39 PM, Christian Ambach wrote:
> >> However, it's not in the posix_acls or vfs_acl_common code as far as I
> >> can tell, because valgrind over that code (now quite well exercised by
> >> samba.tests.posixacl) is clean.
> In case it'll help, I added some talloc_report statements to
> get_nt_acl_internal before it frees the stackframe. See the attachment
> for details (did not want the list to arbitrarly break lines).

Thank you very much for doing that!

The key line is clearly this:

struct security_ace            contains    696 bytes in   1 blocks (ref
0) 0x7f87f49081f0

That is, one (and only one) security_ace remains on frame, and not on
mem_ctx where it should be.  Indeed, it really should be a child of psd
(so as to move with the rest of the SD).

I'll look over the code again, to see if I can find what would generate

Andrew Bartlett

Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org

More information about the samba-technical mailing list