[PATCH][WIP] Make vfs_acl_xattr use hash of the posix ACL

[Christian Ambach]

On 10/31/2012 02:39 PM, Christian Ambach wrote:

>> However, it's not in the posix_acls or vfs_acl_common code as far as I
>> can tell, because valgrind over that code (now quite well exercised by
>> samba.tests.posixacl) is clean.

In case it'll help, I added some talloc_report statements to
get_nt_acl_internal before it frees the stackframe. See the attachment
for details (did not want the list to arbitrarly break lines).

--- a/source3/modules/vfs_acl_common.c
+++ b/source3/modules/vfs_acl_common.c
@@ -670,6 +670,8 @@ static NTSTATUS 
get_nt_acl_internal(vfs_handle_struct *handle,
         /* The VFS API is that the ACL is expected to be on mem_ctx */
         *ppdesc = talloc_move(mem_ctx, &psd);

+       talloc_report_full(frame, stderr);
+       talloc_report_full(mem_ctx, stderr);
         TALLOC_FREE(frame);
         return NT_STATUS_OK;
  }


Cheers,
Christian

-------------- next part --------------
full talloc report on './modules/vfs_acl_common.c:371' (total    700 bytes in   4 blocks)
    .                              contains      2 bytes in   1 blocks (ref 0) 0x7f87f4900f50
    .                              contains      2 bytes in   1 blocks (ref 0) 0x7f87f4901120
    struct security_ace            contains    696 bytes in   1 blocks (ref 0) 0x7f87f49081f0
full talloc report on 'smbd/process.c:3617' (total   9914 bytes in  18 blocks)
    struct security_descriptor     contains    548 bytes in   5 blocks (ref 0) 0x7f87f4907d50
        struct security_acl            contains    372 bytes in   2 blocks (ref 0) 0x7f87f4907f40
            struct security_ace            contains    348 bytes in   1 blocks (ref 0) 0x7f87f4907fc0
        struct dom_sid                 contains     68 bytes in   1 blocks (ref 0) 0x7f87f4907e90
        struct dom_sid                 contains     68 bytes in   1 blocks (ref 0) 0x7f87f4907de0
    ./modules/vfs_acl_common.c:371 contains    700 bytes in   4 blocks (ref 0) 0x7f87f4906a60
        .                              contains      2 bytes in   1 blocks (ref 0) 0x7f87f4900f50
        .                              contains      2 bytes in   1 blocks (ref 0) 0x7f87f4901120
        struct security_ace            contains    696 bytes in   1 blocks (ref 0) 0x7f87f49081f0
    .                              contains      2 bytes in   1 blocks (ref 0) 0x7f87f49069f0
    .                              contains      2 bytes in   1 blocks (ref 0) 0x7f87f4906980
    .                              contains      2 bytes in   1 blocks (ref 0) 0x7f87f4906910
    struct smb_filename            contains    186 bytes in   2 blocks (ref 0) 0x7f87f4906780
        .                              contains      2 bytes in   1 blocks (ref 0) 0x7f87f49068a0
    char                           contains      8 bytes in   1 blocks (ref 0) 0x7f87f4906710
    struct smb_request             contains    274 bytes in   2 blocks (ref 0) 0x7f87f49065f0
        char                           contains     90 bytes in   1 blocks (ref 0) 0x7f87f4906530