s3-vfs: split @GMT token filter code into a common .c
Volker.Lendecke at SerNet.DE
Tue Oct 30 07:58:05 MDT 2012
On Tue, Oct 30, 2012 at 01:22:24PM +0100, David Disseldorp wrote:
> On Tue, 30 Oct 2012 08:41:23 +0100
> Volker Lendecke <Volker.Lendecke at SerNet.DE> wrote:
> > > Please see following patch. Feedback appreciated.
> > While it is a good thing to centralize as much of that logic
> > as possible, please do not #include a .c file. I really,
> > really do not like it in the acl modules and another use of
> > that pattern should be avoided if at all possible. If that
> > means we have to put those routines into core smbd, not
> > sure.
> Thanks for the feedback. In that case I'll go down the route of adding a
> VFS hook to perform what is done by gmt_tok_insert_string().
> The token check code could then eventually be moved out of the VFS if
Ok, after some irc communication I think I understood where
you are going. Sounds good!
> Do you know of anyone using the undocumented snapdirseverywhere option?
Yes, GPFS based systems can require it.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical