s3-vfs: split @GMT token filter code into a common .c

David Disseldorp ddiss at suse.de
Tue Oct 30 06:22:24 MDT 2012

On Tue, 30 Oct 2012 08:41:23 +0100
Volker Lendecke <Volker.Lendecke at SerNet.DE> wrote:

> > Please see following patch. Feedback appreciated.
> While it is a good thing to centralize as much of that logic
> as possible, please do not #include a .c file. I really,
> really do not like it in the acl modules and another use of
> that pattern should be avoided if at all possible. If that
> means we have to put those routines into core smbd, not
> sure.

Thanks for the feedback. In that case I'll go down the route of adding a
VFS hook to perform what is done by gmt_tok_insert_string().
The token check code could then eventually be moved out of the VFS if

Do you know of anyone using the undocumented snapdirseverywhere option?

Cheers, David

More information about the samba-technical mailing list